Skip to content

Add library documentation#7950

Merged
justindbaur merged 4 commits into
mainfrom
add-library-documentation
Jul 15, 2026
Merged

Add library documentation#7950
justindbaur merged 4 commits into
mainfrom
add-library-documentation

Conversation

@justindbaur

Copy link
Copy Markdown
Member

🎟️ Tracking

📔 Objective

Adds the library documentation file references in ADRs 31 and 32. This along with moving fundamental utilities will hopefully enable teams to start on the journey of owning things from the ground up.

📸 Screenshots

@justindbaur justindbaur added the t:docs Change Type - Documentation label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.08%. Comparing base (e0ba28c) to head (1204bed).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7950      +/-   ##
==========================================
+ Coverage   61.45%   62.08%   +0.62%     
==========================================
  Files        2245     2284      +39     
  Lines       98844    99724     +880     
  Branches     8944     9016      +72     
==========================================
+ Hits        60743    61911    +1168     
+ Misses      35952    35638     -314     
- Partials     2149     2175      +26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justindbaur justindbaur marked this pull request as ready for review July 9, 2026 17:18
@justindbaur justindbaur requested a review from a team as a code owner July 9, 2026 17:18
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This documentation PR adds src/Libraries/LIBRARY.md — a canonical shape for libraries under src/Libraries/ — and references it from the writing-server-code skill. Reviewed the new doc's C# examples for correctness, the relative file reference from SKILL.md (resolves correctly), and the Claude configuration change. No security, correctness, or breaking-change concerns; content aligns with ADR-0031/0032 and the repo's dual-ORM and TryAdd* DI conventions.

Code Review Details
  • 🎨 : AddFoo repository example declares an IServiceCollection return type but has no return statement (CS0161 if copied verbatim)
    • src/Libraries/LIBRARY.md:106

Comment thread src/Libraries/LIBRARY.md
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Comment thread .claude/skills/writing-server-code/SKILL.md Outdated
@justindbaur justindbaur requested a review from SaintPatrck July 15, 2026 13:36
@justindbaur justindbaur merged commit aabd1e0 into main Jul 15, 2026
49 checks passed
@justindbaur justindbaur deleted the add-library-documentation branch July 15, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:docs Change Type - Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants